Conversation
✅ Deploy Preview will be available once build job completes!
|
Contributor
|
@sylwang overall, this is excellent. I plan to comment on a few details. But first, a "big picture" question. I know that you can have unmanaged certs with an instance. I'm tempted to recommend moving unmanaged-certificates.md to the content/nginx-one-console/nginx-configs/certificates directory |
mjang
reviewed
Dec 19, 2025
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/config-sync-groups/manage-config-sync-groups.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
Contributor
|
FYI, I'll be working Dec 22, 23, 29, 30, 31. I might be the only writer available during these days -- and I have no problem merging on my own, once we've addressed these suggestions. |
Contributor
|
Note: probable release date now in January 2026 |
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
618a1c6 to
12ea43f
Compare
mjang
reviewed
Jan 27, 2026
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
…aged-certificates.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩